Update ModelBasedESS to use TorchAdapter instead of MapTorchAdapter #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70645611 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3464 +/- ##
==========================================
- Coverage 96.02% 96.02% -0.01%
==========================================
Files 539 539
Lines 52920 52918 -2
==========================================
- Hits 50818 50813 -5
- Misses 2102 2105 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
saitcakmak
force-pushed
the
export-D70645611
branch
from
99f984b to
d0be2a7
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Mar 5, 2025
…acebook#3464) Summary: With the `MapKeyToFloat` transform, we can extract the same data using the `TorchAdapter`, and eliminate the dependency on `MapTorchAdapter` (which we may be deprecating). Differential Revision: D70645611
|
This pull request was exported from Phabricator. Differential Revision: D70645611 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Mar 5, 2025
…acebook#3464) Summary: Pull Request resolved: facebook#3464 With the `MapKeyToFloat` transform, we can extract the same data using the `TorchAdapter`, and eliminate the dependency on `MapTorchAdapter` (which we may be deprecating). Differential Revision: D70645611
saitcakmak
force-pushed
the
export-D70645611
branch
from
d0be2a7 to
a7634b6
Compare
…acebook#3464) Summary: Using the options available on `DataLoaderConfig`, we can extract the same data using the `TorchAdapter`, and eliminate the dependency on `MapTorchAdapter` (which we will be deprecating). We can transition this onto `MapKeyToFloat` down the line, once we clean up `map_keys_as_parameters` logic within the `Adapter`. Differential Revision: D70645611
saitcakmak
force-pushed
the
export-D70645611
branch
from
a7634b6 to
dbc379a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70645611 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Mar 7, 2025
…acebook#3464) Summary: Using the options available on `DataLoaderConfig`, we can extract the same data using the `TorchAdapter`, and eliminate the dependency on `MapTorchAdapter` (which we will be deprecating). We can transition this onto `MapKeyToFloat` down the line, once we clean up `map_keys_as_parameters` logic within the `Adapter`. Differential Revision: D70645611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Using the options available on
DataLoaderConfig, we can extract the same data using theTorchAdapter, and eliminate the dependency onMapTorchAdapter(which we will be deprecating).We can transition this onto
MapKeyToFloatdown the line, once we clean upmap_keys_as_parameterslogic within theAdapter.Differential Revision: D70645611