Updating passing of data loader configs #3465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
SebastianAment
force-pushed
the
export-D70646419
branch
from
8a92df9 to
0d39cf3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70646419 |
SebastianAment
force-pushed
the
export-D70646419
branch
from
0d39cf3 to
eb40b7e
Compare
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Mar 5, 2025
Summary: This commit changes the way data loader configs are passed throughout the code, deprecating the old way of passing e.g. `fit_out_of_design`, in favor of passing a `DataLoaderConfig` object. Differential Revision: D70646419
SebastianAment
force-pushed
the
export-D70646419
branch
from
eb40b7e to
f129074
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70646419 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Mar 5, 2025
Summary: Pull Request resolved: facebook#3465 This commit changes the way data loader configs are passed throughout the code, deprecating the old way of passing e.g. `fit_out_of_design`, in favor of passing a `DataLoaderConfig` object. Differential Revision: D70646419
SebastianAment
force-pushed
the
export-D70646419
branch
from
f129074 to
a51f8f9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70646419 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Mar 5, 2025
Summary: Pull Request resolved: facebook#3465 This commit changes the way data loader configs are passed throughout the code, deprecating the old way of passing e.g. `fit_out_of_design`, in favor of passing a `DataLoaderConfig` object. Differential Revision: D70646419
SebastianAment
force-pushed
the
export-D70646419
branch
2 times, most recently
from
446f8e7 to
ab1f66e
Compare
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Mar 5, 2025
Summary: This commit changes the way data loader configs are passed throughout the code, deprecating the old way of passing e.g. `fit_out_of_design`, in favor of passing a `DataLoaderConfig` object. Differential Revision: D70646419
|
This pull request was exported from Phabricator. Differential Revision: D70646419 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Mar 6, 2025
Summary: This commit changes the way data loader configs are passed throughout the code, deprecating the old way of passing e.g. `fit_out_of_design`, in favor of passing a `DataLoaderConfig` object. Reviewed By: sdaulton, saitcakmak Differential Revision: D70646419
SebastianAment
force-pushed
the
export-D70646419
branch
from
ab1f66e to
f34c772
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70646419 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Mar 6, 2025
Summary: Pull Request resolved: facebook#3465 This commit changes the way data loader configs are passed throughout the code, deprecating the old way of passing e.g. `fit_out_of_design`, in favor of passing a `DataLoaderConfig` object. Reviewed By: sdaulton, saitcakmak Differential Revision: D70646419
SebastianAment
force-pushed
the
export-D70646419
branch
from
f34c772 to
e27e54f
Compare
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Mar 6, 2025
Summary: This commit changes the way data loader configs are passed throughout the code, deprecating the old way of passing e.g. `fit_out_of_design`, in favor of passing a `DataLoaderConfig` object. Reviewed By: sdaulton, saitcakmak Differential Revision: D70646419
SebastianAment
force-pushed
the
export-D70646419
branch
from
e27e54f to
e176018
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70646419 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Mar 6, 2025
Summary: Pull Request resolved: facebook#3465 This commit changes the way data loader configs are passed throughout the code, deprecating the old way of passing e.g. `fit_out_of_design`, in favor of passing a `DataLoaderConfig` object. Reviewed By: sdaulton, saitcakmak Differential Revision: D70646419
SebastianAment
force-pushed
the
export-D70646419
branch
from
e176018 to
cf44fa6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3465 +/- ##
==========================================
- Coverage 96.02% 96.02% -0.01%
==========================================
Files 539 539
Lines 52886 52891 +5
==========================================
+ Hits 50785 50788 +3
- Misses 2101 2103 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: This commit changes the way data loader configs are passed throughout the code, deprecating the old way of passing e.g. `fit_out_of_design`, in favor of passing a `DataLoaderConfig` object. Reviewed By: sdaulton, saitcakmak Differential Revision: D70646419
SebastianAment
force-pushed
the
export-D70646419
branch
from
cf44fa6 to
089946b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70646419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This commit changes the way data loader configs are passed throughout the code, deprecating the old way of passing e.g.
fit_out_of_design, in favor of passing aDataLoaderConfigobject.Differential Revision: D70646419