Move new dispatch utils out of preview #3468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70647193 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Mar 5, 2025
Summary: As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree. Differential Revision: D70647193
mpolson64
force-pushed
the
export-D70647193
branch
from
585fec7 to
5274a0f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70647193 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D70647193 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Mar 5, 2025
Summary: Pull Request resolved: facebook#3468 As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree. Differential Revision: D70647193
mpolson64
force-pushed
the
export-D70647193
branch
from
5274a0f to
12589c6
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Mar 5, 2025
Summary: As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree. Differential Revision: D70647193
mpolson64
force-pushed
the
export-D70647193
branch
from
12589c6 to
a170edf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70647193 |
mpolson64
force-pushed
the
export-D70647193
branch
from
a170edf to
052b311
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Mar 5, 2025
Summary: Pull Request resolved: facebook#3468 As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree. Differential Revision: D70647193
|
This pull request was exported from Phabricator. Differential Revision: D70647193 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Mar 5, 2025
Summary: Pull Request resolved: facebook#3468 As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree. Differential Revision: D70647193
mpolson64
force-pushed
the
export-D70647193
branch
2 times, most recently
from
1cf72b8 to
4fa01eb
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Mar 6, 2025
Summary: As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree. Differential Revision: D70647193
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Mar 6, 2025
Summary: As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree. Differential Revision: D70647193
mpolson64
force-pushed
the
export-D70647193
branch
from
4fa01eb to
5dcd291
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70647193 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D70647193 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Mar 6, 2025
Summary: Pull Request resolved: facebook#3468 As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree. Differential Revision: D70647193
mpolson64
force-pushed
the
export-D70647193
branch
from
5dcd291 to
63e5408
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3468 +/- ##
==========================================
- Coverage 96.03% 96.02% -0.01%
==========================================
Files 539 537 -2
Lines 52904 52887 -17
==========================================
- Hits 50804 50787 -17
Misses 2100 2100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: We have a new choose_generation_strategy in ax.preview.modelbridge that will be migrated out of preview in the next diff. Rename existing choose_generation_strategy to avoid name conflict Differential Revision: D70647194
mpolson64
force-pushed
the
export-D70647193
branch
from
63e5408 to
1f35b3f
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Mar 6, 2025
Summary: As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree. Differential Revision: D70647193
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Mar 6, 2025
Summary: As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree. Differential Revision: D70647193
mpolson64
force-pushed
the
export-D70647193
branch
from
1f35b3f to
772913a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70647193 |
Summary: Pull Request resolved: facebook#3468 As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree. Differential Revision: D70647193
|
This pull request was exported from Phabricator. Differential Revision: D70647193 |
mpolson64
force-pushed
the
export-D70647193
branch
from
772913a to
4970fa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. Also refactored slightly such that we wont be importing from ax.api anywhere in the codebase. To keep our module structure easy to reason about it is very important to keep the ax.api module at the root of our dep tree.
Differential Revision: D70647193