Make choose_analyses pass on base and be an abstract method #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: The implementation of choose_analyses should always be done depending on other attributes, and we have those exisiting methods elsewhere. This seems like it was initially implemented this way during development of the stack and never cleaned up - just cleaning it up as i go. Differential Revision: D70641832
|
This pull request was exported from Phabricator. Differential Revision: D70641832 |
mgarrard
force-pushed
the
export-D70641832
branch
from
412ee3f to
c1c38d4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3469 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 539 539
Lines 52886 52887 +1
=======================================
+ Hits 50785 50786 +1
Misses 2101 2101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The implementation of choose_analyses should always be done depending on other attributes, and we have those exisiting methods elsewhere. This seems like it was initially implemented this way during development of the stack and never cleaned up - just cleaning it up as i go.
Differential Revision: D70641832