Delete MapTorchAdapter #3480
Open
Delete MapTorchAdapter #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acebook#3464) Summary: Using the options available on `DataLoaderConfig`, we can extract the same data using the `TorchAdapter`, and eliminate the dependency on `MapTorchAdapter` (which we will be deprecating). We can transition this onto `MapKeyToFloat` down the line, once we clean up `map_keys_as_parameters` logic within the `Adapter`. Differential Revision: D70645611
Summary: This is not used after D70645611. It's core functionality has been upstreamed into `TorchAdapter` and can be controlled by `DataLoaderConfig`. This was never used in OSS, so not going through a deprecation cycle with warnings before deletion. Differential Revision: D70807349
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70807349 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3480 +/- ##
==========================================
- Coverage 96.02% 96.02% -0.01%
==========================================
Files 539 537 -2
Lines 52920 52739 -181
==========================================
- Hits 50818 50642 -176
+ Misses 2102 2097 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is not used after D70645611. Its core functionality has been upstreamed into
TorchAdapterand can be controlled byDataLoaderConfig.This was never used in OSS, so not going through a deprecation cycle with warnings before deletion.
Differential Revision: D70807349