Skip to content

Commit

Permalink
Fix mismatches due to dep on py_re_client_lib
Browse files Browse the repository at this point in the history
Summary:
from one of the errors in D66006146 :
```
    fbcode//buck2/tests/e2e/test:test_testname_formatting (cfg:windows-x86_64-msvc-clang17-no-san#27c538eff1d66d98) -> fbcode//buck2/tests/e2e/test:test_testname_formatting-library (cfg:windows-x86_64-msvc-clang17-no-san#27c538eff1d66d98) -> fbcode//remote_execution/client_lib/wrappers/python:py_re_client_lib is incompatible with cfg:windows-x86_64-msvc-clang17-no-san#27c538eff1d66d98 (ovr_config//os:linux unsatisfied), check the target's compatibility attributes
```
//remote_execution/client_lib/wrappers/python:py_re_client_lib has compatible_with Linux only.

So specify this accordingly, this matches some of the already existing `skip_for_os` flags nearby anyhow.

Note `xbgs //remote_execution/client_lib/wrappers/python:py_re_client_lib` turns up some 70 other files with `python_binary()`, `python_library()`, `cogwheel_test()` that are not showing up. One theory here is that this only matters for libs that configure for Windows & Mac CI, and fbcode is predominantly Linux.

Reviewed By: scottcao

Differential Revision: D66024771

fbshipit-source-id: 8fb3ab88583fea9e9fe2b1b6e739516c64fd836c
  • Loading branch information
jdonald authored and facebook-github-bot committed Nov 16, 2024
1 parent b203149 commit a8fa901
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions tests/buck_e2e.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ def buck_e2e_test(
ci_deps = ci_deps,
reason = "Non isolated buck2 e2e tests depend heavily on macros",
target = name,
compatible_with = compatible_with,
)

def buck2_e2e_test(
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/test/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ buck2_e2e_test(
srcs = glob([
"test_test_coverage/**/*.py",
]),
compatible_with = ["ovr_config//os:linux"],
skip_for_os = [
"darwin",
"windows",
Expand All @@ -26,6 +27,7 @@ buck2_e2e_test(
buck2_e2e_test(
name = "test_test_artifacts",
srcs = ["test_test_artifacts.py"],
compatible_with = ["ovr_config//os:linux"],
env = {
"TESTX_BIN": "$(exe_target fbsource//xplat/tools:testx)",
},
Expand All @@ -47,6 +49,11 @@ buck2_e2e_test(
buck2_e2e_test(
name = "test_testname_formatting",
srcs = ["test_testname_formatting.py"],
compatible_with = ["ovr_config//os:linux"],
skip_for_os = [
"darwin",
"windows",
],
test_with_deployed_buck2 = True,
use_compiled_buck2_client_and_tpx = True,
deps = [
Expand Down

0 comments on commit a8fa901

Please sign in to comment.