refactor and add tests

facebook · Aug 20, 2024 · b89513b · b89513b
1 parent e2c4322
commit b89513b
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 12 deletions.
diff --git a/packages/docusaurus-plugin-content-blog/src/__tests__/authors.test.ts b/packages/docusaurus-plugin-content-blog/src/__tests__/authors.test.ts
@@ -272,7 +272,13 @@ describe('getBlogPostAuthors', () => {
     expect(
       getBlogPostAuthors({
         frontMatter: {
-          authors: {name: 'Sébastien Lorber', title: 'maintainer'},
+          authors: {
+            name: 'Sébastien Lorber',
+            title: 'maintainer',
+            socials: {
+              github: 'slorber',
+            },
+          },
         },
         authorsMap: undefined,
         baseUrl: '/',
@@ -282,6 +288,9 @@ describe('getBlogPostAuthors', () => {
         name: 'Sébastien Lorber',
         title: 'maintainer',
         imageURL: undefined,
+        socials: {
+          github: 'https://github.com/slorber',
+        },
         key: null,
         page: null,
       },
@@ -293,8 +302,19 @@ describe('getBlogPostAuthors', () => {
       getBlogPostAuthors({
         frontMatter: {
           authors: [
-            {name: 'Sébastien Lorber', title: 'maintainer'},
-            {name: 'Yangshun Tay'},
+            {
+              name: 'Sébastien Lorber',
+              title: 'maintainer',
+              socials: {
+                github: 'slorber',
+              },
+            },
+            {
+              name: 'Yangshun Tay',
+              socials: {
+                github: 'https://github.com/yangshun',
+              },
+            },
           ],
         },
         authorsMap: undefined,
@@ -306,9 +326,20 @@ describe('getBlogPostAuthors', () => {
         title: 'maintainer',
         imageURL: undefined,
         key: null,
+        socials: {
+          github: 'https://github.com/slorber',
+        },
         page: null,
       },
-      {name: 'Yangshun Tay', imageURL: undefined, key: null, page: null},
+      {
+        name: 'Yangshun Tay',
+        imageURL: undefined,
+        key: null,
+        page: null,
+        socials: {
+          github: 'https://github.com/yangshun',
+        },
+      },
     ]);
   });
 
@@ -323,7 +354,12 @@ describe('getBlogPostAuthors', () => {
               title: 'Yangshun title local override',
               extra: 42,
             },
-            {name: 'Alexey'},
+            {
+              name: 'Alexey',
+              socials: {
+                github: 'lex111',
+              },
+            },
           ],
         },
         authorsMap: {
@@ -358,7 +394,15 @@ describe('getBlogPostAuthors', () => {
         imageURL: undefined,
         page: null,
       },
-      {name: 'Alexey', imageURL: undefined, key: null, page: null},
+      {
+        name: 'Alexey',
+        imageURL: undefined,
+        key: null,
+        page: null,
+        socials: {
+          github: 'https://github.com/lex111',
+        },
+      },
     ]);
   });
 

diff --git a/packages/docusaurus-plugin-content-blog/src/authors.ts b/packages/docusaurus-plugin-content-blog/src/authors.ts
@@ -85,8 +85,14 @@ function getFrontMatterAuthors(params: AuthorsParam): Author[] {
         // becoming a name and may end up unnoticed
         return {key: authorInput};
       }
-
-      return authorInput;
+      const normalizedSocials = normalizeSocials(authorInput.socials ?? {});
+
+      return {
+        ...authorInput,
+        ...(Object.keys(normalizedSocials).length > 0 && {
+          socials: normalizedSocials,
+        }),
+      };
     }
 
     return Array.isArray(frontMatter.authors)
@@ -119,16 +125,12 @@ ${Object.keys(authorsMap)
       ...getAuthorsMapAuthor(frontMatterAuthor.key),
       ...frontMatterAuthor,
     };
-    const normalizedSocials = normalizeSocials(frontMatterAuthor.socials ?? {});
 
     return {
       ...author,
       key: author.key ?? null,
       page: author.page ?? null,
       imageURL: normalizeImageUrl({imageURL: author.imageURL, baseUrl}),
-      ...(Object.keys(normalizedSocials).length > 0 && {
-        socials: normalizedSocials,
-      }),
     };
   }
 }