CI tweaks #222
Open
CI tweaks #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to prevent stray changes in the next commits
We're not supporting rubies < 3.0 and 3.0 ships with bundler-2, so current CI setup is unrealistic and also break newer ruby versions. Just use default bundler instead.
Speed up ruby setup a little
Workaround `money` gem issue, see [0] [0] RubyMoney/money@815b618
`irb`, `logger` & `ostruct` are used by SDK and was moved from default to bundled gems in ruby-3.5 [0]. Add them to the gemspec to fix compatibility. We're using `head` in CI instead of `3.5` because it's closer to the final version, see [1] No `continue-on-error` because we're only testing `gem build` for now, which should work with `head` no matter what. Could be skipped later if needed. Fixes facebook#220 [0] https://bugs.ruby-lang.org/issues/20309 [1] ruby/ruby-builder#4 (comment)
Minor ruby-3 kwarg issues, api changes and Symbol/String confusions wrt Hash keys. The single issue in the code is `FacebookAds::ServerSide::Event`, where normalization is not performed when it should be. Fixes 02c4351 Fixes 38f9a07 Fixes facebook#194
|
@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@stcheng any hint what's need to be fixed to pass internal checks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More or less
See commit messages for the details.
No idea why
Facebook GitHub Tools / Meta Import Checksfails, the single added file is.rspec, but maybe it's some changed file.