feat(oss): Get thriftpy3 compiling in OSS #671
+374
−125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This change is intended to land after folly PRs 2503-2507
NOTE: The changes to FBPythonWrapper.cmake duplicate those in folly PR 2505 which is shared internally between folly and fbthrift.
There are three distinct parts to this change:
Removing the use of the ironically deprecated#[deprecated]
macro in Rust (may need a better fix)It also fixes the following build error:Looking at the individual diffs in the PR should help the reviewer see these changes in context.
Tested by running a clean build of EdenFS in Sapling, which needs to import fbthrift with the thriftpy3 flag enabled.