Move determineStrategy from FrescoVitoImage2Spec to VitoImagePipeline…

…Impl Differential Revision: D69949526 fbshipit-source-id: c61ea011569a863d45177250b96d4d23213ee578
facebook · Feb 21, 2025 · 9fb94ef · 9fb94ef
1 parent a2c094f
commit 9fb94ef
Show file tree

Hide file tree

Showing 4 changed files with 87 additions and 77 deletions.
diff --git a/urimod/src/main/java/com/facebook/fresco/urimod/FetchStrategy.kt b/urimod/src/main/java/com/facebook/fresco/urimod/FetchStrategy.kt
@@ -1,4 +1,9 @@
-// (c) Meta Platforms, Inc. and affiliates. Confidential and proprietary.
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
 
 package com.facebook.fresco.urimod
 
@@ -16,6 +21,7 @@ enum class SmartFetchStrategy : FetchStrategy {
 }
 
 enum class ClassicFetchStrategy : FetchStrategy {
+  DEFAULT,
   APP_DISABLED,
   PRODUCT_DISABLED,
   APP_STARTING,

diff --git a/.../core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt b/.../core-java-impl/src/main/java/com/facebook/fresco/vito/core/impl/VitoImagePipelineImpl.kt
@@ -9,6 +9,7 @@ package com.facebook.fresco.vito.core.impl
 
 import android.content.res.Resources
 import android.graphics.Rect
+import android.os.Looper
 import com.facebook.common.callercontext.ContextChain
 import com.facebook.common.references.CloseableReference
 import com.facebook.datasource.DataSource
@@ -204,4 +205,73 @@ class VitoImagePipelineImpl(
       else -> "Other"
     }
   }
+
+  override fun determineFetchStrategy(
+      requestBeforeLayout: VitoImageRequest?,
+      callerContext: Any?,
+      contextChain: ContextChain?
+  ): FetchStrategy {
+    if (requestBeforeLayout == null) {
+      if (experimentalDynamicSizeVito2()) {
+        return SmartFetchStrategy.DEFAULT
+      } else {
+        return NoPrefetchInOnPrepareStrategy
+      }
+    }
+
+    if (!experimentalDynamicSizeVito2()) {
+      return ClassicFetchStrategy.APP_DISABLED
+    }
+
+    if (experimentalDynamicSizeWithCacheFallbackVito2() &&
+        Looper.myLooper() == Looper.getMainLooper()) {
+      // We don't want to check cache if we are running on the main thread
+      // By default uses the original URL
+      val shouldSmartFetchOnMainThread = config.experimentalDynamicSizeOnPrepareMainThreadVito2()
+      if (shouldSmartFetchOnMainThread) {
+        return SmartFetchStrategy.MAIN_THREAD
+      } else {
+        return ClassicFetchStrategy.MAIN_THREAD
+      }
+    }
+
+    if (isProductEnabled(callerContext, contextChain) == false) {
+      return ClassicFetchStrategy.PRODUCT_DISABLED
+    }
+
+    if (config.experimentalDynamicSizeDisableWhenAppIsStarting() && config.isAppStarting()) {
+      return ClassicFetchStrategy.APP_STARTING
+    }
+
+    if (experimentalDynamicSizeWithCacheFallbackVito2()) {
+      val isInDiskCache =
+          isInDiskCacheSync(
+              requestBeforeLayout,
+              config.experimentalDynamicSizeDiskCacheCheckTimeoutMs(),
+              TimeUnit.MILLISECONDS)
+
+      if (isInDiskCache == null) {
+        // Disk cache request timed out
+        if (config.experimentalDynamicSizeUseSfOnDiskCacheTimeout()) {
+          return SmartFetchStrategy.DISK_CACHE_TIMEOUT
+        } else {
+          return ClassicFetchStrategy.DISK_CACHE_TIMEOUT
+        }
+      }
+
+      if (isInDiskCache) {
+        // Disk MBP fallback
+        return ClassicFetchStrategy.DISK_CACHE_HIT
+      }
+    }
+
+    return SmartFetchStrategy.DEFAULT
+  }
+
+  private fun isProductEnabled(callerContext: Any?, contextChain: ContextChain?): Boolean? {
+    if (!config.experimentalDynamicSizeCheckIfProductIsEnabled()) {
+      return null
+    }
+    return config.experimentalDynamicSizeIsProductEnabled(callerContext, contextChain)
+  }
 }
diff --git a/vito/core/src/main/java/com/facebook/fresco/vito/core/VitoImagePipeline.kt b/vito/core/src/main/java/com/facebook/fresco/vito/core/VitoImagePipeline.kt
@@ -12,6 +12,7 @@ import android.graphics.Rect
 import com.facebook.common.callercontext.ContextChain
 import com.facebook.common.references.CloseableReference
 import com.facebook.datasource.DataSource
+import com.facebook.fresco.urimod.ClassicFetchStrategy
 import com.facebook.fresco.urimod.FetchStrategy
 import com.facebook.fresco.vito.options.ImageOptions
 import com.facebook.fresco.vito.source.ImageSource
@@ -67,4 +68,10 @@ interface VitoImagePipeline {
   }
 
   fun hintUnmodifiedUri(imageRequest: VitoImageRequest) = Unit
+
+  fun determineFetchStrategy(
+      requestBeforeLayout: VitoImageRequest?,
+      callerContext: Any?,
+      contextChain: ContextChain?
+  ): FetchStrategy = ClassicFetchStrategy.DEFAULT
 }
diff --git a/vito/litho/src/main/java/com/facebook/fresco/vito/litho/FrescoVitoImage2Spec.kt b/vito/litho/src/main/java/com/facebook/fresco/vito/litho/FrescoVitoImage2Spec.kt
@@ -13,7 +13,6 @@ import android.content.pm.ActivityInfo
 import android.graphics.Rect
 import android.net.Uri
 import android.os.Build
-import android.os.Looper
 import android.view.View
 import androidx.core.util.ObjectsCompat
 import androidx.core.view.accessibility.AccessibilityNodeInfoCompat
@@ -62,7 +61,6 @@ import com.facebook.litho.annotations.ShouldExcludeFromIncrementalMount
 import com.facebook.litho.annotations.ShouldUpdate
 import com.facebook.litho.annotations.TreeProp
 import com.facebook.litho.utils.MeasureUtils
-import java.util.concurrent.TimeUnit
 
 /** Fresco Vito component for Litho */
 @MountSpec(isPureRender = true, canPreallocate = true, poolSize = 15)
@@ -165,7 +163,9 @@ object FrescoVitoImage2Spec {
       prefetchDataSource: Output<DataSource<Void?>>,
       fetchStrategy: Output<FetchStrategy>,
   ) {
-    val result = determineFetchStrategy(requestBeforeLayout, callerContext, contextChain)
+    val result =
+        FrescoVitoProvider.getImagePipeline()
+            .determineFetchStrategy(requestBeforeLayout, callerContext, contextChain)
     when (result) {
       is ClassicFetchStrategy -> {
         checkNotNull(requestBeforeLayout)
@@ -184,14 +184,6 @@ object FrescoVitoImage2Spec {
     fetchStrategy.set(result)
   }
 
-  private fun isProductEnabled(callerContext: Any?, contextChain: ContextChain?): Boolean? {
-    val config = FrescoVitoProvider.getConfig()
-    if (!config.experimentalDynamicSizeCheckIfProductIsEnabled()) {
-      return null
-    }
-    return config.experimentalDynamicSizeIsProductEnabled(callerContext, contextChain)
-  }
-
   @JvmStatic
   @OnMount
   fun onMount(
@@ -517,69 +509,4 @@ object FrescoVitoImage2Spec {
       }
     }
   }
-
-  /** Determine whether to SmartFetch for a given request */
-  private fun determineFetchStrategy(
-      requestBeforeLayout: VitoImageRequest?,
-      callerContext: Any?,
-      contextChain: ContextChain?
-  ): FetchStrategy {
-    if (requestBeforeLayout == null) {
-      if (experimentalDynamicSizeVito2()) {
-        return SmartFetchStrategy.DEFAULT
-      } else {
-        return NoPrefetchInOnPrepareStrategy
-      }
-    }
-
-    if (!experimentalDynamicSizeVito2()) {
-      return ClassicFetchStrategy.APP_DISABLED
-    }
-
-    if (experimentalDynamicSizeWithCacheFallbackVito2() &&
-        Looper.myLooper() == Looper.getMainLooper()) {
-      // We don't want to check cache if we are running on the main thread
-      // By default uses the original URL
-      val shouldSmartFetchOnMainThread = experimentalDynamicSizeOnPrepareMainThreadVito2()
-      if (shouldSmartFetchOnMainThread) {
-        return SmartFetchStrategy.MAIN_THREAD
-      } else {
-        return ClassicFetchStrategy.MAIN_THREAD
-      }
-    }
-
-    if (isProductEnabled(callerContext, contextChain) == false) {
-      return ClassicFetchStrategy.PRODUCT_DISABLED
-    }
-
-    val config = FrescoVitoProvider.getConfig()
-    if (config.experimentalDynamicSizeDisableWhenAppIsStarting() && config.isAppStarting()) {
-      return ClassicFetchStrategy.APP_STARTING
-    }
-
-    if (experimentalDynamicSizeWithCacheFallbackVito2()) {
-      val isInDiskCache =
-          FrescoVitoProvider.getImagePipeline()
-              .isInDiskCacheSync(
-                  requestBeforeLayout,
-                  FrescoVitoProvider.getConfig().experimentalDynamicSizeDiskCacheCheckTimeoutMs(),
-                  TimeUnit.MILLISECONDS)
-
-      if (isInDiskCache == null) {
-        // Disk cache request timed out
-        if (config.experimentalDynamicSizeUseSfOnDiskCacheTimeout()) {
-          return SmartFetchStrategy.DISK_CACHE_TIMEOUT
-        } else {
-          return ClassicFetchStrategy.DISK_CACHE_TIMEOUT
-        }
-      }
-
-      if (isInDiskCache) {
-        // Disk MBP fallback
-        return ClassicFetchStrategy.DISK_CACHE_HIT
-      }
-    }
-
-    return SmartFetchStrategy.DEFAULT
-  }
 }