Move React Native Hermes build to static_h #1749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
coado
changed the title
|
@coado has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
|
@coado has updated the pull request. You must reimport the pull request before landing. |
|
@coado has updated the pull request. You must reimport the pull request before landing. |
2 similar comments
|
@coado has updated the pull request. You must reimport the pull request before landing. |
|
@coado has updated the pull request. You must reimport the pull request before landing. |
cortinico
requested changes
Sep 1, 2025
cortinico
approved these changes
Sep 10, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
Summary: This diff moves new builds from main to static_h branch and adjusts/fixes failing jobs which includes: - Fix tvOS and visionOS apple slices build by including missing `stdio.h` in `Logging.cpp`. - Fix Android build by linking `compileJS` with `hermesHBCBackend`. The windows build job is failing because Static Hermes does not currently support builds with MSVC. Pull Request resolved: #1749 Test Plan: Signals Reviewed By: cortinico Differential Revision: D79996969 Pulled By: coado fbshipit-source-id: 4a6c0e7cef77e6bed48e97779aa86c83de9aa1da
|
@coado has updated the pull request. You must reimport the pull request before landing. |
coado
changed the title
coado
added a commit
to coado/hermes
that referenced
this pull request
Sep 12, 2025
Summary: This diff moves new builds from main to static_h branch and adjusts/fixes failing jobs which includes: - Fix tvOS and visionOS apple slices build by including missing `stdio.h` in `Logging.cpp`. - Fix Android build by linking `compileJS` with `hermesHBCBackend`. The windows build job is failing because Static Hermes does not currently support builds with MSVC. Pull Request resolved: facebook#1749 Test Plan: Signals Reviewed By: cortinico Differential Revision: D79996969 Pulled By: coado fbshipit-source-id: 4a6c0e7cef77e6bed48e97779aa86c83de9aa1da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Work in progress. Preparing build workflows on Static Hermes.
Test Plan