-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain format on programatic updates #5707
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
@@ -286,6 +286,8 @@ function onSelectionChange( | |||
} | |||
} | |||
|
|||
const previousSelection = editor._editorState._selection; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivailop7 to use $getPreviousSelection
I'd have to do .getEditorState.read
, do you think it's worth it, particularly when this is run at every single selection change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, can skip.
Follow up on #5692
Screen.Recording.2024-03-12.at.2.37.16.PM.mov
Closes #5620
Potential follow up #5708