Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export toggleTextFormatType from LexicalUtils #5815

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spirobel
Copy link
Contributor

@spirobel spirobel commented Apr 3, 2024

this is necessary so we can override toggleFormat on an extended TextNode that selectively disallows certain format types.

this is necessary so we can override toggleFormat on an extended TextNode that selectively disallows certain format types.
Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 5:26pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 5:26pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2024
@StyleT
Copy link
Contributor

StyleT commented Apr 23, 2024

LGTM if you can write proper JSDoc (with detailed description, use cases/examples) for this new exported function.

@potatowagon
Copy link
Contributor

putting back to draft since awaiting documentation as per @StyleT 's comment

@potatowagon potatowagon marked this pull request as draft April 30, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants