-
Notifications
You must be signed in to change notification settings - Fork 2k
[lexical-offset] Bug Fix: inline element selection, match user input observed behaviour with text nodes #7753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… end over next node start
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The most important thing to do when adding fixes here would be to add tests that show what the fixes are supposed to do, confirm that they work, and ensure that they continue to work as the rest of the code changes. |
Hi @etrepum, thanks for checking the PR! You are right, the PR is not there yet, hence I created just as a draft one. |
Add initial set of tests for createSelectionFromOffsets
…eater than its last child node\'s end by 1'
… of 1' Small refactor
Description
inline element selection (multiple)
prefer text node end over next node start (TODO should detail out separately for collapsed selection?)
Describe the changes in this pull request
Closes #7580 (TODO double-check and create bugs for the other issues...)
Test plan
Before
Insert relevant screenshots/recordings/automated-tests
After
Insert relevant screenshots/recordings/automated-tests