[lexical-markdown] Option: $convertToMarkdownString with shouldPreserveWhitespaces #7972
+92
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baptistejamin
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
Collaborator
|
This fails the formatting check (should be able to fix with |
Contributor
Author
|
Thank you for the report. It has been fixed. |
etrepum
reviewed
Nov 8, 2025
Collaborator
etrepum
left a comment
etrepum
left a comment
There was a problem hiding this comment.
The only thing missing here are tests to show that it does what it's supposed to
etrepum
reviewed
Nov 9, 2025
| $convertToMarkdownString([...TRANSFORMERS], undefined, false, true), | ||
| ); | ||
|
|
||
| expect(exported).toBe('** Hello **'); |
Collaborator
There was a problem hiding this comment.
Looking closer at what this is supposed to do now that there are tests I don't think this is useful, because this is not something most markdown parsers will accept.
For example here's what github does with it:
** Hello **
The commonmark reference implementation also doesn't parse it as formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[lexical-markdown] Option: $convertToMarkdownString with shouldPreserveWhitespaces
Description
By default, $convertToMarkdownString replaces whitespaces in somecases with HTML chars:
**   foo   **, while it's not a big deal when exporting from Lexical and then rendering into Lexical, it breaks on other Markdown renderers.