Revert "[lexical-react] [lexical-playground] Remove old ContextMenu, consolidate LexicalMenu render" #7997
+596
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consolid…" This reverts commit d1a8e84.
ivailop7
requested review from
acywatson,
etrepum,
fantactuka,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
bot
added
the
CLA Signed
zurfyx
approved these changes
Nov 18, 2025
Member
zurfyx
left a comment
zurfyx
left a comment
There was a problem hiding this comment.
Approving to unblock but I would personally hold on merging until @jrfitzsimmons and @thatmichael85 have had a chance to review it and explore further adoption options. As we discussed, I genuinely think that this PR provides clear benefits for an existing anchoring problem (including externally in the community and internally at Meta), and just happens to be not so immediately compatible with the way we do component design systems.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7984