Skip to content

Conversation

@patrick-atticus
Copy link
Contributor

@patrick-atticus patrick-atticus commented Nov 19, 2025

Description

A backwards selection partially within a table does not select the contents of the first cell.

This means copy/paste drops the first cell.

Update the selection to start at the beginning of the cell so the full tables contents is included.

Test plan

Updated selections tests to capture new (correct) behavior

Before

CleanShot.2025-11-19.at.16.18.52.mp4

@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lexical Ready Ready Preview Comment Nov 19, 2025 11:25pm
lexical-playground Ready Ready Preview Comment Nov 19, 2025 11:25pm

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2025
@patrick-atticus patrick-atticus changed the title [lexical-table] Bug Fix: include first cell contents in backwards table selection [lexical-table] Bug Fix: include first cell contents in partial backwards table selection Nov 19, 2025
ivailop7
ivailop7 previously approved these changes Nov 19, 2025
@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label Nov 19, 2025
@etrepum etrepum added this pull request to the merge queue Nov 21, 2025
Merged via the queue into facebook:main with commit b2a9e93 Nov 21, 2025
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants