Kernel 4.1: ftgmac: Increase maximum NC-SI response payload size #2
Conversation
Summary: Increase max NC-SI response payload to 1480 in kernel for big response packets that are used in Broadcom OEM GetDebugData. Test plan: - fby2 and fbgp2 image build (pass) - Update and boot the image on YosemiteV2 and V2.5 (pass) - BMC initializes NC-SI interface with NIC (pass) - Use ncsi-util send various commands such as 0x18, 0x19 and 0x1a (pass) - Use ncsi-util to perform PLDM firmware update (pass) - Use ncsi-uitl Broadcom OEM GetDebugData command to retrieve core dump and crash dump from NIC (pass)
|
Hi @xzhang-brcm! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Hi @xzhang-brcm , thanks a lot for this update! I will work with internal team to add this to next release. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@benwei13 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Increase max NC-SI response payload to 1480 in kernel for big response packets that are used in Broadcom OEM GetDebugData. Signed-off-by: Xiaobing Zhang [email protected] Closes #2 Test Plan: - fby2 and fbgp2 image build (pass) - Update and boot the image on YosemiteV2 and V2.5 (pass) - BMC initializes NC-SI interface with NIC (pass) - Use ncsi-util send various commands such as 0x18, 0x19 and 0x1a (pass) - Use ncsi-util to perform PLDM firmware update (pass) - Use ncsi-uitl Broadcom OEM GetDebugData command to retrieve core dump and crash dump from NIC (pass) root@dhcp-10-67-92-132:~# ncsi-util -m brcm -d coredump -o /tmp/nic.core Debug data length: 14216032 Received: 14216032/14216032 (100%) GetDebugData completed root@dhcp-10-67-92-132:~# ncsi-util -m brcm -d crashdump -o /tmp/nic.crash Debug data length: 47824 Received: 47824/47824 (100%) GetDebugData completed Reviewed By: tao-ren Differential Revision: D23288998 Pulled By: benwei13 fbshipit-source-id: 6c03c79011
3 participants
Summary:
Increase max NC-SI response payload to 1480 in kernel for big response packets
that are used in Broadcom OEM GetDebugData.
Test plan:
crash dump from NIC (pass)
root@dhcp-10-67-92-132:~# ncsi-util -m brcm -d coredump -o /tmp/nic.core
Debug data length: 14216032
Received: 14216032/14216032 (100%)
GetDebugData completed
root@dhcp-10-67-92-132:~# ncsi-util -m brcm -d crashdump -o /tmp/nic.crash
Debug data length: 47824
Received: 47824/47824 (100%)
GetDebugData completed