Skip to content

Commit

Permalink
Avoid crashing the server when fast incremental build fails on `buck …
Browse files Browse the repository at this point in the history
…query`

Reviewed By: dkgi

Differential Revision: D30529461

fbshipit-source-id: ac1923743055652e317a45c8ea6e3844d434a6c4
  • Loading branch information
grievejia authored and facebook-github-bot committed Aug 25, 2021
1 parent c40ee9e commit ee74ba3
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions source/buck/builder.ml
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,9 @@ let compute_difference_from_changed_paths ~source_root ~buck_options ~targets ch
|> Lwt.return_ok
with
| JsonError message -> Lwt.return_error message
| Raw.BuckError { description; _ } ->
let message = Format.sprintf "Buck query failed: %s" description in
Lwt.return_error message


let build_map_and_difference_from_paths
Expand Down

0 comments on commit ee74ba3

Please sign in to comment.