relative modules on import #1193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: completion for the <> in from .<> imports currently don't work. in this diff, I implement basic support for them: - if we have a config and this file is in that config, use the absolute import path for them - if this fails, use the fallback_search_path at the level of the dots we still don't have support for go-to definition / hover on these relative modules. fixes facebook#874 Differential Revision: D83351301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
completion for the <> in from .<> imports currently don't work.
in this diff, I implement basic support for them:
we still don't have support for go-to definition / hover on these relative modules.
fixes #874
Differential Revision: D83351301