fix Types from the typing module are currently not clickable in type hints #1681

[asukaminato0721]

Summary

Fixes #1681

Reworked the type-label plumbing so OutputWithLocations now emits TypeLabelPart records that carry both the rendered text and optional TypeSymbolReference metadata (module/name) whenever we render known symbols (e.g., via maybe_fmt_with_module). This involved extending the TypeOutput trait with write_symbol and updating all implementations/tests accordingly.

In the LSP transaction, added resolve_type_symbol_reference to import typing/typing_extensions modules on demand and attach their source locations to inlay-hint label parts when the original type string lacked a location. Both return-type and variable-type hint builders now fall back to this resolver before emitting each label part.

Test Plan

Strengthened coverage with a new end-to-end LSP test that asserts Literal label parts point into typing.pyi, alongside the existing goto-type-definition test. The display-layer tests were also updated to exercise the richer label parts and verify Literal parts carry typing metadata.

[jvansch1]

Thanks for taking a look at this! I have been looking at this as well as #1683 and I am wondering if there is one solution that we can use for both of these. It seems like to get tuples working we are including the entire stdlib along with TypeOutput which seems like a large lift for just that purpose. I am wondering if we could also combine that logic with what we do here somehow. What do you think?

[Copilot]

Pull request overview

This PR fixes issue #1681 by making types from the typing module clickable in LSP inlay hints. The implementation adds metadata tracking for type symbols (module/name pairs) through a new TypeSymbolReference structure and enriches TypeLabelPart records to carry both rendered text and optional symbol references. The LSP layer resolves these symbols on-demand to their source locations in typing.pyi or typing_extensions.pyi, enabling IDE features like go-to-definition for types like Literal, Any, and other typing constructs.

Key Changes:

• Introduced TypeSymbolReference and TypeLabelPart structures to track symbol metadata alongside display text
• Added write_symbol method to TypeOutput trait for emitting symbols with module/name information
• Implemented resolve_type_symbol_reference in LSP transaction to dynamically resolve typing module symbols to their stub file locations
• Updated display logic to use maybe_fmt_with_module for SpecialForm types, enabling clickability for Literal, TypeGuard, etc.
• Refactored test infrastructure with helper functions for structured inlay hint validation

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pyrefly/lib/test/lsp/lsp_interaction/util.rs	Added helper functions inlay_hints_match_expected, ExpectedInlayHint, and ExpectedTextEdit for structured test assertions
pyrefly/lib/test/lsp/lsp_interaction/notebook_inlay_hint.rs	Migrated from JSON-based test expectations to structured helper functions
pyrefly/lib/test/lsp/lsp_interaction/inlay_hint.rs	Migrated tests to structured helpers and added test_inlay_hint_typing_literals_have_locations to verify Literal symbols resolve to typing.pyi
pyrefly/lib/lsp/wasm/inlay_hints.rs	Added resolve_type_symbol_reference method with re-export following and integrated symbol resolution into return-type and variable-type hint builders
crates/pyrefly_types/src/type_output.rs	Introduced TypeSymbolReference and TypeLabelPart, added write_symbol to trait, updated all implementations and tests
crates/pyrefly_types/src/display.rs	Modified maybe_fmt_with_module to use write_symbol, updated SpecialForm handling, attempted TypedDict changes (contains bugs), updated test helpers

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.