Skip to content

Conversation

floydkim
Copy link
Contributor

@floydkim floydkim commented Oct 4, 2025

This PR fixes the guide for generating source maps during iOS builds.

Following the current guide as-is does not generate a source map file.
This diff adds export to the environment variable declaration so that child processes can read the SOURCEMAP_FILE variable.

If child processes can't read the SOURCEMAP_FILE, react-native-xcode.sh script will not recognize it, and -output-source-map option will not be added when executing hermesc.
As a result, the source map file is not generated.

export-sourcemap-env.mov

@meta-cla meta-cla bot added the CLA Signed label Oct 4, 2025
Copy link

netlify bot commented Oct 4, 2025

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit e1adde2
🔍 Latest deploy log https://app.netlify.com/projects/react-native/deploys/68ee683a4aaed3000850bb5e
😎 Deploy Preview https://deploy-preview-4832--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @floydkim, thanks for spotting that issue and providing a correction! 🙏

Can you update also newly cut 0.82 docs file? Can be in a separate PR if you want, just LMK. This one is fine to ship otherwise!

@Simek Simek added the Needs Author Feedback An issue or PR which needs the feedback or response from the author. label Oct 14, 2025
@Simek
Copy link
Collaborator

Simek commented Oct 14, 2025

Thanks for the quick update, let's ship it! 🚀

@Simek Simek removed the Needs Author Feedback An issue or PR which needs the feedback or response from the author. label Oct 14, 2025
@floydkim
Copy link
Contributor Author

@Simek Wow. I was going to let you know after the GitHub checks were finished, but you saw it already!
Thank you as always for your hard work.

@Simek Simek merged commit 95942c2 into facebook:main Oct 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants