Skip to content

Commit

Permalink
Enable vector drawable support by default (#48347)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #48347

Vector drawable support was added behind a feature flag in #45354 and is ready to release more widely. This change is effectively the same as removing the feature flag but allows our holdout to continue until mid-January.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D67482531

fbshipit-source-id: 1733c4748f79fd4df72f531a24efcbd8a7822611
  • Loading branch information
Abbondanzo authored and facebook-github-bot committed Dec 30, 2024
1 parent 6dd4195 commit a3c8e21
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<d21071fcbf501d1e7aba6b227ef74351>>
* @generated SignedSource<<ad4ecf46a017b05a22046b772504f889>>
*/

/**
Expand Down Expand Up @@ -95,7 +95,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun lazyAnimationCallbacks(): Boolean = false

override fun loadVectorDrawablesOnImages(): Boolean = false
override fun loadVectorDrawablesOnImages(): Boolean = true

override fun traceTurboModulePromiseRejectionsOnAndroid(): Boolean = false

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<14f964cf6d43943bdeed783d28c231e0>>
* @generated SignedSource<<570853d015d4f41ef4eb0a7896a96e96>>
*/

/**
Expand Down Expand Up @@ -172,7 +172,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}

bool loadVectorDrawablesOnImages() override {
return false;
return true;
}

bool traceTurboModulePromiseRejectionsOnAndroid() override {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ const definitions: FeatureFlagDefinitions = {
},
},
loadVectorDrawablesOnImages: {
defaultValue: false,
defaultValue: true,
metadata: {
dateAdded: '2024-07-12',
description:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<a35c5b22c0f20cb50ceaf56a856c9c8f>>
* @generated SignedSource<<fb2e049d649b9bf7ef6bd0e26523b4ef>>
* @flow strict
*/

Expand Down Expand Up @@ -337,7 +337,7 @@ export const lazyAnimationCallbacks: Getter<boolean> = createNativeFlagGetter('l
/**
* Adds support for loading vector drawable assets in the Image component (only on Android)
*/
export const loadVectorDrawablesOnImages: Getter<boolean> = createNativeFlagGetter('loadVectorDrawablesOnImages', false);
export const loadVectorDrawablesOnImages: Getter<boolean> = createNativeFlagGetter('loadVectorDrawablesOnImages', true);
/**
* Enables storing js caller stack when creating promise in native module. This is useful in case of Promise rejection and tracing the cause.
*/
Expand Down

0 comments on commit a3c8e21

Please sign in to comment.