Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement prop diffing for border props in <View> #48831

Closed
wants to merge 4 commits into from
+507 −0
Closed

Implement prop diffing for border props in <View> #48831

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2e646a
[skip ci] Introduce getDiffProps for <View> (#45552)
mdvacca Jan 22, 2025
f450be2
[skip ci] Implement prop diffing for basic props in <View> (#48829)
mdvacca Jan 22, 2025
373b2f7
[skip ci] Implement prop diffing for event props in <View> (#48830)
mdvacca Jan 22, 2025
28bcaa4
Implement prop diffing for border props in <View> (#48831)
mdvacca Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading

Unchanged files with check annotations Beta

View file
packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js
// and testing the react-test-renderer instead of the real one.
// The react test renderer is now deprecated, so there is no value in keeping this test
// as it is.
it.skip('integrates with React and handles a key error in LogBox', () => {

Check warning on line 66 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

GitHub Actions / test_js (20) 

Disabled test

Check warning on line 66 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

GitHub Actions / test_js (18) 

Disabled test
const spy = jest.spyOn(LogBoxData, 'addLog');
installLogBox();
// and testing the react-test-renderer instead of the real one.
// The react test renderer is now deprecated, so there is no value in keeping this test
// as it is.
it.skip('integrates with React and handles a fragment warning in LogBox', () => {

Check warning on line 127 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

GitHub Actions / test_js (20) 

Disabled test

Check warning on line 127 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

GitHub Actions / test_js (18) 

Disabled test
const spy = jest.spyOn(LogBoxData, 'addLog');
installLogBox();
View file
packages/react-native/Libraries/Utilities/ReactNativeTestTools.js
/* eslint-env jest */
import type {ReactTestRenderer as ReactTestRendererType} from 'react-test-renderer';

Check warning on line 13 in packages/react-native/Libraries/Utilities/ReactNativeTestTools.js

GitHub Actions / test_js (20) 

Requires should be sorted alphabetically

Check warning on line 13 in packages/react-native/Libraries/Utilities/ReactNativeTestTools.js

GitHub Actions / test_js (18) 

Requires should be sorted alphabetically
import TouchableWithoutFeedback from '../Components/Touchable/TouchableWithoutFeedback';
View file
packages/react-native/src/private/webapis/dom/nodes/__tests__/ReactNativeElement-itest.js
describe('getRootNode()', () => {
// This is the desired implementation (not implemented yet).
it.skip('returns a root node representing the document', () => {

Check warning on line 257 in packages/react-native/src/private/webapis/dom/nodes/__tests__/ReactNativeElement-itest.js

GitHub Actions / test_js (20) 

Disabled test

Check warning on line 257 in packages/react-native/src/private/webapis/dom/nodes/__tests__/ReactNativeElement-itest.js

GitHub Actions / test_js (18) 

Disabled test
let lastParentANode;
let lastParentBNode;
let lastChildANode;