Fix request permission is not always resolving in Android 16 #53898
+31
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D83059478. |
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java
Outdated
Show resolved
Hide resolved
|
@gabrieldonadel any timeline regarding when this issue could be resolved? |
gabrieldonadel
approved these changes
Oct 2, 2025
|
@gabrieldonadel will there be a release with this fix for react native 0.79? |
3 tasks
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D83059478. |
|
This pull request was successfully merged by @lukmccall in 39ede95 When will my fix make it into a release? | How to file a pick request? |
|
will this be included in version 0.81.5? |
|
@irekrog there's a pick request open for 0.81: reactwg/react-native-releases#1151 |
react-native-bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
Summary: Fixes: #53887 Fixes: expo/expo#39480 In the latest Android 16 update, requesting permissions does not always change the app's state (the `onPause` and `onResume` functions aren't called). For instance, when you deny permission 3 times, the last promise won't resolve until you move the app to the background. The current logic inside the `ReactActivityDelegate` assumes that Android will call `onResume` after receiving permission state information from the system, which is no longer the case. Probably connected with [this commit](https://android.googlesource.com/platform/packages/modules/Permission/%2B/5dca0ccb26f2b99d706a1d3e9402f851e849c913) ## Changelog: [ANDROID] [FIXED] - Fix request permission not always resolving in Android 16 Pull Request resolved: #53898 Test Plan: - I've tested it in the RNTester by denying the camera permission three times. - I've also checked if the patch works with the Expo permissions code. Reviewed By: javache Differential Revision: D83059478 Pulled By: cortinico fbshipit-source-id: 7bf33b379a1b6606ad2da2f75d337bf951e3986b
|
This pull request was successfully merged by @lukmccall in 447a7a3 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes: #53887
Fixes: expo/expo#39480
In the latest Android 16 update, requesting permissions does not always change the app's state (the
onPauseandonResumefunctions aren't called). For instance, when you deny permission 3 times, the last promise won't resolve until you move the app to the background. The current logic inside theReactActivityDelegateassumes that Android will callonResumeafter receiving permission state information from the system, which is no longer the case.Probably connected with this commit
Changelog:
[ANDROID] [FIXED] - Fix request permission not always resolving in Android 16
Test Plan: