-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Add responderIgnoreScroll prop on ScrollView #53951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zeyap
wants to merge
1
commit into
facebook:main
Choose a base branch
from
zeyap:export-D82761242
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Sep 25, 2025
Summary: ## Changelog: [Android] [Changed] - Add responderIgnoreScroll prop on ScrollView When it's set to true (default), emit touchcancel from native Android ScrollView, instead of letting Responder System terminate responder at scroll. When false, `onTouchCancel` on ScrollView children will not be invoked, but `onTouchEnd` will be invoked (if touch starts on it) - which aligns with iOS. Allow opting in this new behavior at component level because (1) touchCancel is meaningful especially on android, and dev may be using onTouchCancel handler, if we enable this everywhere the handler is broken, (2) there's likely some issue in responder system when transferring js responder Differential Revision: D82761242
5d01c54
to
da3a9b8
Compare
|
Summary: ## Changelog: [Android] [Changed] - Add responderIgnoreScroll prop on ScrollView When it's set to true (default), emit touchcancel from native Android ScrollView, instead of letting Responder System terminate responder at scroll. When false, `onTouchCancel` on ScrollView children will not be invoked, but `onTouchEnd` will be invoked (if touch starts on it) - which aligns with iOS. Allow opting in this new behavior at component level because (1) touchCancel is meaningful especially on android, and dev may be using onTouchCancel handler, if we enable this everywhere the handler is broken, (2) there's likely some issue in responder system when transferring js responder Differential Revision: D82761242
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Sep 25, 2025
Summary: ## Changelog: [Android] [Changed] - Add responderIgnoreScroll prop on ScrollView When it's set to true (default), emit touchcancel from native Android ScrollView, instead of letting Responder System terminate responder at scroll. When false, `onTouchCancel` on ScrollView children will not be invoked, but `onTouchEnd` will be invoked (if touch starts on it) - which aligns with iOS. Allow opting in this new behavior at component level because (1) touchCancel is meaningful especially on android, and dev may be using onTouchCancel handler, if we enable this everywhere the handler is broken, (2) there's likely some issue in responder system when transferring js responder Differential Revision: D82761242
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Sep 25, 2025
Summary: ## Changelog: [Android] [Changed] - Do not emit touchCancel at scroll if responderIgnoreScroll is disabled Last change facebook#53951 added `responderIgnoreScroll` prop to ScrollView on android; here is native implementation Differential Revision: D82675049
da3a9b8
to
dd78d2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
meta-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Android] [Changed] - Add responderIgnoreScroll prop on ScrollView
When it's set to true (default), emit touchcancel from native Android ScrollView, instead of letting Responder System terminate responder at scroll. When false,
onTouchCancel
on ScrollView children will not be invoked, butonTouchEnd
will be invoked (if touch starts on it) - which aligns with iOS.Allow opting in this new behavior at component level because (1) touchCancel is meaningful especially on android, and dev may be using onTouchCancel handler, if we enable this everywhere the handler is broken, (2) there's likely some issue in responder system when transferring js responder
Differential Revision: D82761242