Add support for .ktx images #53964
Open
Add support for .ktx images #53964
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toreVR Summary: # What Moving Store from `arvr/js` to `xplat/js`. This will enable Store to use xplat modern infra. Being on arvr/js legacy infra has created many problems [over the years](https://fb.workplace.com/groups/storecore/posts/2344707442611890/?comment_id=2345657702516864). Examples: **2025**: https://fb.workplace.com/groups/storecore/permalink/2344707442611890/ **2024**: https://fb.workplace.com/groups/oculusjs/permalink/3366314690341563/ **2023**: https://fb.workplace.com/groups/xplatreact.engineering/permalink/730125568732098/ # How ## Previous Diff * Remove usage of the legacy `react-router-3`. We don't want to carry this as a dependency to xplat/js. ## This Diff This diff is the combination of several diffs (created to facilitate reviewing): 1. - D82581768 - Just move files from arvr/js/apps/Store to xplat/js/RKJSModules/public/HzStoreVR (Except for the index file and some mockUtils) 2. - D82581767 - Setup getConfig.js to generate a single BUCK for HzStoreVR and remove circular dependencies 3. - D82581769 - Fix location/import of assets 4. - D82581766 - Fix relay imports that were not using Haste 5. - D82664586 - Remove usage of old url module 6. - D83156829 - Fix buck: run js1 build buckfiles and build_and_run.sh 7. - D82844768 - Make arvr/js tests run with xplat Store 8. - D83005059 - Fix Flow errors 9. - D83259512 - Delete duplicated test files to make flow happy 10. - D83005098 - Fix Relay config for new Store VR location in xplat 11. - D83005073 - Enable React Forget on new HzStoreVR directory 12. - D83345573 - Fix arc lint -a ## Next diffs * Migrate tests to xplat jest config (renaming from *-rntest.js to *-test.js) * Migrate other source code like arvr/js/libraries/store Reviewed By: Tom910, mullender Differential Revision: D82781491
meta-cla
bot
added
the
CLA Signed
gorodscy
changed the title
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 28, 2025
…toreVR Summary: # What Moving Store from `arvr/js` to `xplat/js`. This will enable Store to use xplat modern infra. Being on arvr/js legacy infra has created many problems [over the years](https://fb.workplace.com/groups/storecore/posts/2344707442611890/?comment_id=2345657702516864). Examples: **2025**: https://fb.workplace.com/groups/storecore/permalink/2344707442611890/ **2024**: https://fb.workplace.com/groups/oculusjs/permalink/3366314690341563/ **2023**: https://fb.workplace.com/groups/xplatreact.engineering/permalink/730125568732098/ # How ## Previous Diff * Remove usage of the legacy `react-router-3`. We don't want to carry this as a dependency to xplat/js. ## This Diff This diff is the combination of several diffs (created to facilitate reviewing): 1. - D82581768 - Just move files from arvr/js/apps/Store to xplat/js/RKJSModules/public/HzStoreVR (Except for the index file and some mockUtils) 2. - D82581767 - Setup getConfig.js to generate a single BUCK for HzStoreVR and remove circular dependencies 3. - D82581769 - Fix location/import of assets 4. - D82581766 - Fix relay imports that were not using Haste 5. - D82664586 - Remove usage of old url module 6. - D83156829 - Fix buck: run js1 build buckfiles and build_and_run.sh 7. - D82844768 - Make arvr/js tests run with xplat Store 8. - D83005059 - Fix Flow errors 9. - D83259512 - Delete duplicated test files to make flow happy 10. - D83005098 - Fix Relay config for new Store VR location in xplat 11. - D83005073 - Enable React Forget on new HzStoreVR directory 12. - D83345573 - Fix arc lint -a 13. - D83403188 - Fix relay prefetch queries ## Next diffs * Migrate tests to xplat jest config (renaming from *-rntest.js to *-test.js) * Migrate other source code like arvr/js/libraries/store ## Open Source PR For the change to RN open source .flowconfig to add .ktx image support: #53964 Changelog: [Internal] Reviewed By: Tom910, mullender Differential Revision: D82781491 fbshipit-source-id: 5ce6433916e5b144965e8906005e2e26fdcfcc95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for .ktx images in flowconfig
Reviewed By: Tom910, mullender
Differential Revision: D82781491