Pass down frameRateListenerCallback in cxx animated #54142
Closed
+77
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 20, 2025
…k#54142) Summary: ## Changelog: [Internal] [Added] - Allow passing down frameRateListenerCallback in cxx animated exposing `frameRateListenerCallback` to add instrumentation at animation frame and stop we're deferring the actual implementation of frame rate listening/logging to app/platform side Reviewed By: sammy-SC Differential Revision: D84510183
zeyap
force-pushed
the
export-D84510183
branch
2 times, most recently
from
dff77bc to
d511f78
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 20, 2025
…k#54142) Summary: ## Changelog: [Internal] [Added] - Allow passing down frameRateListenerCallback in cxx animated exposing `frameRateListenerCallback` to add instrumentation at animation frame and stop we're deferring the actual implementation of frame rate listening/logging to app/platform side Reviewed By: sammy-SC Differential Revision: D84510183
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 20, 2025
…k#54142) Summary: ## Changelog: [Internal] [Added] - Allow passing down frameRateListenerCallback in cxx animated exposing `frameRateListenerCallback` to add instrumentation at animation frame and stop we're deferring the actual implementation of frame rate listening/logging to app/platform side Reviewed By: sammy-SC Differential Revision: D84510183
zeyap
force-pushed
the
export-D84510183
branch
2 times, most recently
from
cc32baf to
9931074
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 21, 2025
…k#54142) Summary: ## Changelog: [Internal] [Added] - Allow passing down frameRateListenerCallback in cxx animated exposing `frameRateListenerCallback` to add instrumentation at animation frame and stop we're deferring the actual implementation of frame rate listening/logging to app/platform side Reviewed By: sammy-SC Differential Revision: D84510183
zeyap
force-pushed
the
export-D84510183
branch
from
9931074 to
748b72a
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 21, 2025
…k#54142) Summary: ## Changelog: [Internal] [Added] - Allow passing down frameRateListenerCallback in cxx animated exposing `frameRateListenerCallback` to add instrumentation at animation frame and stop we're deferring the actual implementation of frame rate listening/logging to app/platform side Reviewed By: sammy-SC Differential Revision: D84510183
zeyap
force-pushed
the
export-D84510183
branch
from
748b72a to
b16fa86
Compare
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 21, 2025
…k#54142) Summary: ## Changelog: [Internal] [Added] - Allow passing down frameRateListenerCallback in cxx animated exposing `frameRateListenerCallback` to add instrumentation at animation frame and stop we're deferring the actual implementation of frame rate listening/logging to app/platform side Reviewed By: sammy-SC Differential Revision: D84510183
…54211) Summary: ## Changelog: [Internal] [Added] - always invoke onRender via UIManagerNativeAnimatedDelegate Previously only android invokes `onRender` via UIManagerNativeAnimatedDelegate::runAnimationFrame() consolidating so it's easier for debugging, also in cases where we want to add extra work per frame (e.g. add performance logging) in AnimatedNodesManagerProvider Reviewed By: sammy-SC Differential Revision: D85071075
…k#54142) Summary: ## Changelog: [Internal] [Added] - Allow passing down frameRateListenerCallback in cxx animated exposing `frameRateListenerCallback` to add instrumentation at animation frame and stop we're deferring the actual implementation of frame rate listening/logging to app/platform side Reviewed By: sammy-SC Differential Revision: D84510183
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Oct 22, 2025
…k#54142) Summary: ## Changelog: [Internal] [Added] - Allow passing down frameRateListenerCallback in cxx animated exposing `frameRateListenerCallback` to add instrumentation at animation frame and stop we're deferring the actual implementation of frame rate listening/logging to app/platform side Reviewed By: sammy-SC Differential Revision: D84510183
zeyap
force-pushed
the
export-D84510183
branch
2 times, most recently
from
20cdaf0 to
fca5ef0
Compare
|
This pull request has been merged in 9f7a3bb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Added] - Pass down frameRateListenerCallback in cxx animated
exposing
frameRateListenerCallbackto add instrumentation at animation frame and stopwe're deferring the actual implementation of frame rate listening/logging to app/platform side
Differential Revision: D84510183