fix(community-cli-plugin): Add description in target debugs to distinguish RN Bridge and reanimated #54198
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As I point out in this issue, when integration reanimated, we end up with two debug targets having the same title. This can confuse and lead people to think something is wrong.
Adding the description alongside the title to better explain where the second debug target comes from eliminates the confusion.
Changelog:
[General] [Fixed] - Add description to target debugs to differentiate RNBridge and Reanimated debug targets
Test Plan:
Tested in this RN 82 project with the latest reanimated by overriding the code in the
node_moduleBefore:
After:
