Skip to content

Group sampling methods in header files #54243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Group sampling methods in header files #54243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...ges/react-native/ReactCommon/hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,7 @@ class HermesRuntimeTargetDelegate : public RuntimeTargetDelegate {
size_t framesToSkip) override;

void enableSamplingProfiler() override;

void disableSamplingProfiler() override;

tracing::RuntimeSamplingProfile collectSamplingProfile() override;

std::optional<folly::dynamic> serializeStackTrace(
Expand Down
6 changes: 0 additions & 6 deletions packages/react-native/ReactCommon/jsinspector-modern/RuntimeTarget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,10 @@ class RuntimeTargetDelegate {
* Start sampling profiler.
*/
virtual void enableSamplingProfiler() = 0;

/**
* Stop sampling profiler.
*/
virtual void disableSamplingProfiler() = 0;

/**
* Return recorded sampling profile for the previous sampling session.
*/
Expand Down Expand Up @@ -148,12 +146,10 @@ class RuntimeTargetController {
* Start sampling profiler for the corresponding RuntimeTarget.
*/
void enableSamplingProfiler();

/**
* Stop sampling profiler for the corresponding RuntimeTarget.
*/
void disableSamplingProfiler();

/**
* Return recorded sampling profile for the previous sampling session.
*/
Expand Down Expand Up @@ -227,12 +223,10 @@ class JSINSPECTOR_EXPORT RuntimeTarget
* Start sampling profiler for a particular JavaScript runtime.
*/
void enableSamplingProfiler();

/**
* Stop sampling profiler for a particular JavaScript runtime.
*/
void disableSamplingProfiler();

/**
* Return recorded sampling profile for the previous sampling session.
*/
Expand Down
Loading