Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back out "[bundles] stop building legacy Paper renderer (#31429)" #31437

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Nov 6, 2024

Backs out the 2 related commits:

Since I only realized when syncing that we need the version of react and the legacy renderer to match.

While I investigate if there's anything we can do to work around that while preserving the legacy renderer, this unblocks the sync.

…)"

Backs out the 2 related commits:
- facebook@f8f6e1a
- facebook@6c0f37f

Since I only realized when syncing that we need the version of `react` and the legacy renderer to match.

While I investigate if there's anything we can do to work around that while preserving the legacy renderer, this unblocks the sync.
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 2:38pm

@react-sizebot
Copy link

The size diff is too large to display in a single comment. The GitHub action for this pull request contains an artifact called 'sizebot-message.md' with the full message.

Generated by 🚫 dangerJS against 8ccc291

@kassens kassens merged commit 3149685 into facebook:main Nov 6, 2024
187 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
…1437)

Backs out the 2 related commits:
-
f8f6e1a
-
6c0f37f

Since I only realized when syncing that we need the version of `react`
and the legacy renderer to match.

While I investigate if there's anything we can do to work around that
while preserving the legacy renderer, this unblocks the sync.

DiffTrain build for [3149685](3149685)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants