Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler] Outline JSX with non-jsx children #31442

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

gsathya
Copy link
Member

@gsathya gsathya commented Nov 6, 2024

Previously, we bailed out on outlining jsx that had children that were not part of the outlined jsx.

Now, we add support for children by treating as attributes.

Previously, we bailed out on outlining jsx that had children that were
not part of the outlined jsx.

Now, we add support for children by treating as attributes.

ghstack-source-id: f8d88aa867847db17ab2b07c574fa5216069a666
Pull Request resolved: facebook#31400
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 5:53pm

@gsathya
Copy link
Member Author

gsathya commented Nov 6, 2024

Approved here: #31400

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Nov 6, 2024
@gsathya gsathya merged commit a88b9e5 into facebook:main Nov 6, 2024
18 of 19 checks passed
@gsathya gsathya deleted the rename-outlined-attr branch November 6, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants