Track "Animating" Entry for Gestures while the Gesture is Still On-going #34548
+110
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: 05b61f8...66c6a35 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
approved these changes
Sep 22, 2025
sebmarkbage
force-pushed
the
gesturecommitphase
branch
from
7436b11 to
683c7db
Compare
We need to clear any updates scheduled so that we can treat future updates as the cause of the render.
If you're gesturing to something new and there are no updating or disappearing view transitions, then all view transitions are "exit" (because gestures are in reverse). These use the clone model which should track the animation task the same as applyViewTransitionToHostInstances. We also need to start the tracking earlier so it covers the insertion of clones.
We don't actually ever use this because startGestureTransition is not allowed to be async and so we never show the delta in time from when it starts until the optimistic update happens.
sebmarkbage
force-pushed
the
gesturecommitphase
branch
from
683c7db to
66c6a35
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
…ing (#34548) Stacked on #34546. Same as #34538 but for gestures. Includes various fixes. This shows how it ends with a Transition when you release in the committed state. Note how the Animation of the Gesture continues until the Transition is done so that the handoff is seamless. <img width="853" height="134" alt="Screenshot 2025-09-20 at 7 37 29 PM" src="https://github.com/user-attachments/assets/6192a033-4bec-43b9-884b-77e3a6f00da6" /> DiffTrain build for [e233218](e233218)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
…ing (#34548) Stacked on #34546. Same as #34538 but for gestures. Includes various fixes. This shows how it ends with a Transition when you release in the committed state. Note how the Animation of the Gesture continues until the Transition is done so that the handoff is seamless. <img width="853" height="134" alt="Screenshot 2025-09-20 at 7 37 29 PM" src="https://github.com/user-attachments/assets/6192a033-4bec-43b9-884b-77e3a6f00da6" /> DiffTrain build for [e233218](e233218)
EugeneChoi4
pushed a commit
to EugeneChoi4/react
that referenced
this pull request
Sep 24, 2025
…ing (facebook#34548) Stacked on facebook#34546. Same as facebook#34538 but for gestures. Includes various fixes. This shows how it ends with a Transition when you release in the committed state. Note how the Animation of the Gesture continues until the Transition is done so that the handoff is seamless. <img width="853" height="134" alt="Screenshot 2025-09-20 at 7 37 29 PM" src="https://github.com/user-attachments/assets/6192a033-4bec-43b9-884b-77e3a6f00da6" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #34546.
Same as #34538 but for gestures.
Includes various fixes.
This shows how it ends with a Transition when you release in the committed state. Note how the Animation of the Gesture continues until the Transition is done so that the handoff is seamless.