Skip to content

Fix StringAnalyzer bug and Add Integer.parseInt #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix StringAnalyzer bug and Add Integer.parseInt #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c63238
Fix StringAnalyzer bug and Add Integer.parseInt
fa1conn Oct 31, 2022
caccac0
Fix StringAnalyzer bug and Add Integer.parseInt
fa1conn Oct 31, 2022
448a145
Add Integer.parseInt
fa1conn Nov 1, 2022
17e492d
Add Integer.parseInt
fa1conn Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libredex/Purity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ static const std::string_view pure_method_names[] = {
"Ljava/lang/Integer;.toString:(I)Ljava/lang/String;",
"Ljava/lang/Integer;.toString:(II)Ljava/lang/String;",
"Ljava/lang/Integer;.valueOf:(I)Ljava/lang/Integer;",
"Ljava/lang/Integer;.parseInt:(Ljava/lang/String;)I",
"Ljava/lang/Long;.bitCount:(J)I",
"Ljava/lang/Long;.compareTo:(Ljava/lang/Long;)I",
"Ljava/lang/Long;.doubleValue:()D",
Expand Down
3 changes: 2 additions & 1 deletion libredex/WellKnownTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,11 @@
FOR_EACH(java_lang_Integer_valueOf, \
"Ljava/lang/Integer;.valueOf:(I)Ljava/lang/Integer;") \
FOR_EACH(java_lang_Integer_intValue, "Ljava/lang/Integer;.intValue:()I") \
FOR_EACH(java_lang_Integer_parseInt, "Ljava/lang/Integer;.parseInt:(Ljava/lang/String;)I") \
FOR_EACH(java_lang_Throwable_fillInStackTrace, \
"Ljava/lang/Throwable;.fillInStackTrace:()Ljava/lang/Throwable;") \
FOR_EACH(java_lang_RuntimeException_init_String, \
"Ljava/lang/RuntimeException;.<init>:(Ljava/lang/String;)V") \
FOR_EACH(java_lang_String_equals, \
"Ljava/lang/String;.equals:(Ljava/lang/Object;)Z") \
FOR_EACH(java_lang_String_hashCode, "Ljava/lang/String;.hashCode:()I")
FOR_EACH(java_lang_String_hashCode, "Ljava/lang/String;.hashCode:()I")
7 changes: 7 additions & 0 deletions service/constant-propagation/ConstantPropagationAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,13 @@ bool StringAnalyzer::analyze_invoke(const IRInstruction* insn,
env->set(RESULT_REGISTER, SignedConstantDomain(res));
return true;
}
}else if (method == method::java_lang_Integer_parseInt()){
if (const auto* arg0 = maybe_string(0)) {
const char* int_ = arg0->c_str();
int64_t res = atoi(int_);
env->set(RESULT_REGISTER, SignedConstantDomain(res));
return true;
}
}

return false;
Expand Down