[WIP] Transform to convert @requried to Client Controlled Nullability #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captbaritone
commented
Jun 24, 2022
| GITHUB_ROOT=$(dirname "$SCRIPT_DIR") | ||
|
|
||
| cd "$GITHUB_ROOT"/compiler || exit | ||
| cargo run --bin fixture_tests_bin --quiet --release -- \ |
There was a problem hiding this comment.
We need to add a version of this to open source.
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketch (code is quite rough) of a transform to attempt to convert @required directives to the equivalent Client Controlled Nullability semantics.
Some @required patterns cannot be expressed. For these we create an error.
Much more work to do here before it can be useful (or even correct), but I got to a good stopping place and wanted to with some folks.