-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix requestCache conflicts when have multiple ReactRelayQueryRenderer #4632
base: main
Are you sure you want to change the base?
fix: fix requestCache conflicts when have multiple ReactRelayQueryRenderer #4632
Conversation
Hi @hannanstd! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
At this point we are not investing in improving the older higher-order-components APIs and are instead focused on the hooks-based APIs. Do the hooks apis ( |
@captbaritone |
14d51da
to
054e65c
Compare
ef85cc6
to
8286425
Compare
8286425
to
97248ab
Compare
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Sometimes we have to have two or more
ReactRelayQueryRenderer
with different environments at the same time.So the problem is that
requestCache
is used as a shared variable to hold both environments's caches.On the other hand, as you know each environment can have its
configName
while we creating it.It makes sense that the
requestCacheKey
consists of thisconfigName
to isolate each environment from the others.This PR does that. see the added Unit Tests.
Also, it can solve some issues that were reported before regarding the SSR.