reset seen error when resume succeed. #12772
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteemann
reviewed
Jun 14, 2024
db/db_impl/db_impl.cc
Outdated
| @@ -422,6 +422,11 @@ Status DBImpl::ResumeImpl(DBRecoverContext context) { | |||
| // finish. Those previouly waiting threads can now proceed, which may | |||
| // include closing the db. | |||
| s = error_handler_.ClearBGError(); | |||
| log_write_mutex_.Lock(); | |||
| for (auto& log : logs_) { | |||
| log.writer.file()->reset_seen_error(); | |||
There was a problem hiding this comment.
The code did not compile for me. I think log.writer is a pointer.
Suggested change
| log.writer.file()->reset_seen_error(); | |
| log.writer->file()->reset_seen_error(); |
There was a problem hiding this comment.
I've fixed this and add a test.
There was a problem hiding this comment.
@liyichao : thanks for your fix! Note that I am not affiliated with the RocksDB team. I was just trying your PR locally.
There was a problem hiding this comment.
@liyichao I think there were some concerns about the approach on the linked issue: #11643 (comment)
|
Side note: I tried the change to check if it would fix #9762 as well, but it doesn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11643