Disable track_and_verify_wals=1 with write fault injection only when pessimistic txn in stress test
#13360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jaykorean ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context/Summary:
#13263 temporally disabled
track_and_verify_wals=1with write fault injection in all cases to mitigate a WAL hole surfaced bytrack_and_verify_wals=1not fully debugged at that time. Fully debugging shows the WAL hole only happens under pessimistic TXN when two-phase-commit (2pc) was used.The bug essentially is about 2pc won't be able to discard the corrupted WAL as it would in non-2pc case as part of the WAL write error recovery. So the corrupted WAL will still present in the next DB open and caught by
track_and_verify_wals=1.This fix is going to take a while. So for now, let's reduce the scope of disabling the testing.
Test:
Monitor stress test for WAL recovery error/corruption