Add forward declaration for InternalIterator in memtable.h #13957
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a forward declaration for
InternalIterator
inmemtable.h
to improve header self-containment and follow C++ best practices.Problem
The
memtable.h
header file usesInternalIterator
type in its interface (specifically inReadOnlyMemTable::NewIterator()
andReadOnlyMemTable::NewTimestampStrippingIterator()
methods) but doesn't provide a forward declaration or include the corresponding header file. This violates the self-contained header principle.Solution
Added a forward declaration for
InternalIterator
in the forward declarations section ofmemtable.h
.Changes
class InternalIterator;
forward declaration inmemtable.h
Impact
Testing
Additional Notes
While the current code compiles successfully (likely due to indirect includes through other headers), adding the forward declaration makes the dependency explicit and prevents potential issues if the include chain changes in the future.
This is a preventive optimization that improves code quality without affecting functionality.