cmake - support zstd config packages #13982
Open
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xingbowang @pdillinger can you please take a look? |
|
huh, check-format step is failing, but it seems unrelated to this PR - check is suggesting to change many unrelated lines and the formatting seems to be not configured - it's suggesting a lot of unnecessary indentation. |
|
Found an issue with format-diff.sh that should resolve problem that CI was indicating, added a note to PR first post. |
As it's actually a cmake file and trying to format it with clang-format results in obscure syntax.
Andrej730
force-pushed
the
zstd-config-package
branch
from
3305add to
ca347a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's possible to pass zstd on Windows to rocksdb cmake without modifying thirdparty.inc / setting environment variables, resolves Support
find_packagefor zstd in cmake on Windows #13948For consistency changed non-Windows code to look for zstd config package first too and then fallback for module search. Shouldn't hurt and maybe it will be the main way to detect zstd in the future and we'll be able to get rid of findzstd.cmake.
Had an issue running CI on this PR - format-diff.sh was trying to format
thirparty.incwithclang-formatwhich didn't worked since this .inc is actually a cmake file. Excluded it from format-diff. Probably, a proper solution would be to rename it tothirdparty.cmake, but I'm not sure about possible implications (maybe someone was modifyingthirdparty.incin their scripts when building rocksdb and renaming it could cause issues).