Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
third-party/rust: pin unicode-width to solve an issue with cell width…
… in prettytable-rs when using cell containing string formatted with Colored crate. Summary: I have noticed that recently `metalctl` CLI started rendering table with wrong cells widths: {F1946659102} After looking around I found this [Issue](phsym/prettytable-rs#165) reported exactly the same problem. In `metalos` we **do** use Colored crate: https://www.internalfb.com/code/fbsource/[769b00238690]/fbcode/metalos/metald/if/rust/src/api.rs?lines=206-220 And this messes up with the width. An user in that GH issue reported pinning unicode-width to 0.1.12 works around the problem hence this is what I am doing this. This started happening after `unicode-width` got bumped in tp2 from `0.1.12` to `0.1.14` on the 21st of October: https://www.internalfb.com/phabricator/commit/FBS/7c9387478e0a3a1d1876ec4a5a17599510994711 I am aware pinning dependencies asks for trouble e.g. duplication etc. We can remove the pin after this issue is fixed in `prettytable-rs` and I added a comment about that in Cargo.toml Differential Revision: D64960800 fbshipit-source-id: 7fa29b15b1cae7d5a0f75a44f0d4f221e78c7a91
- Loading branch information