Fix flaky test_big_file test by increasing client timeout #1324
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing with SocketTimeout because the pywatchman client in WatchmanInstance.start() used the default 1 second timeout, which is too short on resource-constrained systems (e.g., Windows CI running tests with 2GB/4GB files). Changes: - Increase client connection timeout from 1s to up to 10s - Catch SocketTimeout in addition to SocketConnectError so the startup loop can retry on timeout
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D90087810. (Because this pull request was imported automatically, there will not be any future comments.) |
|
This pull request has been merged in 32c84e2. |
meta-codesync bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jan 6, 2026
Summary: The test was failing with SocketTimeout because the pywatchman client in WatchmanInstance.start() used the default 1 second timeout, which is too short on resource-constrained systems (e.g., Windows CI running tests with 2GB/4GB files). Changes: - Increase client connection timeout from 1s to up to 10s - Catch SocketTimeout in addition to SocketConnectError so the startup loop can retry on timeout X-link: facebook/watchman#1324 Reviewed By: genevievehelsel Differential Revision: D90087810 fbshipit-source-id: 4ad3c33229b0b2a2cff89bb4a820d2b85f433238
ptarjan
pushed a commit
to ptarjan/watchman
that referenced
this pull request
Jan 7, 2026
The test_big_file test was failing intermittently on Windows CI due to SocketTimeout errors. The pywatchman client was using a short default timeout of 1 second, which is insufficient on resource-constrained systems. This fix: - Increases the client connection timeout to up to 10 seconds - Catches SocketTimeout in addition to SocketConnectError in the retry loop This matches the fix from PR facebook#1324.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing with SocketTimeout because the pywatchman client in WatchmanInstance.start() used the default 1 second timeout, which is too short on resource-constrained systems (e.g., Windows CI running tests with 2GB/4GB files).
Changes: