This repository was archived by the owner on Sep 27, 2019. It is now read-only.
disambiguate wording for __FILE__#114
Open
gregory-nisbet wants to merge 1 commit intofacebookarchive:masterfrom
gregory-nisbet:patch-2
Open
disambiguate wording for __FILE__#114gregory-nisbet wants to merge 1 commit intofacebookarchive:masterfrom gregory-nisbet:patch-2
gregory-nisbet wants to merge 1 commit intofacebookarchive:masterfrom
gregory-nisbet:patch-2
Conversation
With the original wording, it's hard to tell whether `__FILE__` refers to just the last component of the path (sometimes called the name of a file) or the complete path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the original wording, it's hard to tell whether
__FILE__refers to just the last component of the path (sometimes called the name of a file) or the complete path.