Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Update MIRAI to work with latest nightly #1228

Merged
merged 11 commits into from
Jul 29, 2023
Merged

Update MIRAI to work with latest nightly #1228

merged 11 commits into from
Jul 29, 2023

Conversation

hermanventer
Copy link
Contributor

@hermanventer hermanventer commented Jul 29, 2023

Description

Update MIRAI to work with latest nightly

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

./validate.sh

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2023
@hermanventer hermanventer changed the title Update MI Update MIRAI to work with latest nightly Jul 29, 2023
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #1228 (99e9fc5) into main (850e729) will increase coverage by 0%.
The diff coverage is 73%.

@@          Coverage Diff           @@
##            main   #1228    +/-   ##
======================================
  Coverage     74%     74%            
======================================
  Files         23      23            
  Lines      16537   16771   +234     
======================================
+ Hits       12336   12515   +179     
- Misses      4201    4256    +55     
Files Changed Coverage Δ
checker/src/constant_domain.rs 55% <ø> (+<1%) ⬆️
checker/src/crate_visitor.rs 71% <ø> (ø)
checker/src/options.rs 83% <40%> (+4%) ⬆️
checker/src/path.rs 83% <50%> (-1%) ⬇️
checker/src/block_visitor.rs 74% <64%> (-1%) ⬇️
checker/src/type_visitor.rs 75% <72%> (-1%) ⬇️
checker/src/utils.rs 84% <75%> (-1%) ⬇️
checker/src/call_visitor.rs 77% <79%> (-1%) ⬇️
checker/src/body_visitor.rs 84% <97%> (-1%) ⬇️
checker/src/callbacks.rs 66% <100%> (ø)
... and 3 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hermanventer hermanventer merged commit ed3f3b5 into main Jul 29, 2023
7 of 8 checks passed
@hermanventer hermanventer deleted the nightly branch July 29, 2023 06:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants