build: Remove needless gflags::gflags workaround
#14829
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's needed for old CMake such as CMake 3.16. CMake 3.18 or later can create an alias CMake target for non-`GLOBAL` CMake target: https://cmake.org/cmake/help/latest/command/add_library.html#alias-libraries > Added in version 3.18: An ALIAS can target a non-GLOBAL Imported > Target. Such alias is scoped to the directory in which it is created > and below. The ALIAS_GLOBAL target property can be used to check if > the alias is global or not. Now, we require CMake 3.28 or later. So we can remove the `gflags_gflags` workaround. I confirmed that this change works with Presto C++.
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14760
It's needed for old CMake such as CMake 3.16. CMake 3.18 or later can create an alias CMake target for non-
GLOBALCMake target:https://cmake.org/cmake/help/latest/command/add_library.html#alias-libraries
Now, we require CMake 3.28 or later. So we can remove the
gflags_gflagsworkaround.I confirmed that this change works with Presto C++.