Skip to content

fix(fuzzer): Disable streaming aggregation for Spark fuzzer test #14831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(fuzzer): Disable streaming aggregation for Spark fuzzer test #14831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/scheduled.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,7 @@ jobs:
--seed ${random_seed} \
--duration_sec $DURATION \
--enable_sorted_aggregations=false \
--enable_streaming_aggregations=false \
--minloglevel=0 \
--stderrthreshold=2 \
--log_dir=/tmp/spark_aggregate_fuzzer_repro/logs \
Expand Down
17 changes: 11 additions & 6 deletions velox/exec/fuzzer/AggregationFuzzer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ DEFINE_bool(
true,
"When true, generates plans with aggregations over sorted inputs");

DEFINE_bool(
enable_streaming_aggregations,
true,
"When true, generates plans with streaming aggregations");

using facebook::velox::fuzzer::CallableSignature;
using facebook::velox::fuzzer::SignatureTemplate;

Expand Down Expand Up @@ -741,7 +746,7 @@ bool AggregationFuzzer::verifyAggregation(
projections,
tableScanPlans);

if (!groupingKeys.empty()) {
if (FLAGS_enable_streaming_aggregations && !groupingKeys.empty()) {
// Use OrderBy + StreamingAggregation on original input.
makeStreamingPlansWithTableScan(
groupingKeys,
Expand Down Expand Up @@ -772,7 +777,7 @@ bool AggregationFuzzer::verifyAggregation(
makeAlternativePlansWithValues(
groupingKeys, aggregates, masks, flatInput, projections, valuesPlans);

if (!groupingKeys.empty()) {
if (FLAGS_enable_streaming_aggregations && !groupingKeys.empty()) {
// Use OrderBy + StreamingAggregation on original input.
makeStreamingPlansWithValues(
groupingKeys, aggregates, masks, input, projections, valuesPlans);
Expand Down Expand Up @@ -839,7 +844,7 @@ bool AggregationFuzzer::verifySortedAggregation(
std::vector<PlanWithSplits> plans;
plans.push_back({firstPlan, {}});

if (!groupingKeys.empty()) {
if (FLAGS_enable_streaming_aggregations && !groupingKeys.empty()) {
plans.push_back(
{PlanBuilder()
.values(input)
Expand Down Expand Up @@ -869,7 +874,7 @@ bool AggregationFuzzer::verifySortedAggregation(
.planNode(),
splits});

if (!groupingKeys.empty()) {
if (FLAGS_enable_streaming_aggregations && !groupingKeys.empty()) {
plans.push_back(
{PlanBuilder()
.tableScan(inputRowType)
Expand Down Expand Up @@ -1135,7 +1140,7 @@ bool AggregationFuzzer::verifyDistinctAggregation(
std::vector<PlanWithSplits> plans;
plans.push_back({firstPlan, {}});

if (!groupingKeys.empty()) {
if (FLAGS_enable_streaming_aggregations && !groupingKeys.empty()) {
plans.push_back(
{PlanBuilder()
.values(input)
Expand Down Expand Up @@ -1167,7 +1172,7 @@ bool AggregationFuzzer::verifyDistinctAggregation(
.planNode(),
splits});

if (!groupingKeys.empty()) {
if (FLAGS_enable_streaming_aggregations && !groupingKeys.empty()) {
plans.push_back(
{PlanBuilder()
.tableScan(inputRowType)
Expand Down
Loading