This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Implement config validation to find unused keys #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D25321360 |
mannatsingh
added a commit
to mannatsingh/ClassyVision
that referenced
this pull request
Jan 23, 2021
Summary: Pull Request resolved: facebookresearch#665 Implement a `ClassyConfigDict` type which supports tracking reads and freezing the map (the latter is unused currently). Added it to `build_task` to catch cases where we don't use any keys passed by users. This will not catch all instances, like when some components do a deepcopy - we assume all the keys and sub-keys are read in such a situation Differential Revision: D25321360 fbshipit-source-id: fa74e7dc9b850b035bf7dd1fb4a26aaad99b896b
mannatsingh
force-pushed
the
export-D25321360
branch
from
09b9170 to
b7d33c7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25321360 |
mannatsingh
added a commit
to mannatsingh/ClassyVision
that referenced
this pull request
Jan 23, 2021
Summary: Pull Request resolved: facebookresearch#665 Implement a `ClassyConfigDict` type which supports tracking reads and freezing the map (the latter is unused currently). Added it to `build_task` to catch cases where we don't use any keys passed by users. This will not catch all instances, like when some components do a deepcopy - we assume all the keys and sub-keys are read in such a situation Differential Revision: D25321360 fbshipit-source-id: d5bd63c5340575171a1847739025eea7aec576f1
mannatsingh
force-pushed
the
export-D25321360
branch
from
b7d33c7 to
f5ea2af
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25321360 |
mannatsingh
added a commit
to mannatsingh/ClassyVision
that referenced
this pull request
Jan 23, 2021
Summary: Pull Request resolved: facebookresearch#665 Implement a `ClassyConfigDict` type which supports tracking reads and freezing the map (the latter is unused currently). Added it to `build_task` to catch cases where we don't use any keys passed by users. This will not catch all instances, like when some components do a deepcopy - we assume all the keys and sub-keys are read in such a situation Differential Revision: D25321360 fbshipit-source-id: ff71e61298baa6c30d0e4719ec5512a20fda955c
mannatsingh
force-pushed
the
export-D25321360
branch
from
f5ea2af to
a27e7a6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25321360 |
Summary: Pull Request resolved: facebookresearch#665 Implement a `ClassyConfigDict` type which supports tracking reads and freezing the map (the latter is unused currently). Added it to `build_task` to catch cases where we don't use any keys passed by users. This will not catch all instances, like when some components do a deepcopy - we assume all the keys and sub-keys are read in such a situation Differential Revision: D25321360 fbshipit-source-id: c98b99977cfcbf98c669c0da29b10320ec7efc77
mannatsingh
force-pushed
the
export-D25321360
branch
from
a27e7a6 to
9f2732c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D25321360 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implement a
ClassyMaptype which supports tracking reads and freezing the map (the latter is unused currently).Added it to
ClassificationTaskto catch cases where we don't use any keys passed by users.This will not catch all instances, like when some components do a deepcopy - we assume all the keys and sub-keys are read in such a situation
Differential Revision: D25321360