Skip to content

fix: correct unzip filename typo in README experiment logs section#18

Open
voidborne-d wants to merge 1 commit intofacebookresearch:mainfrom
voidborne-d:fix-readme-unzip-typo
Open

fix: correct unzip filename typo in README experiment logs section#18
voidborne-d wants to merge 1 commit intofacebookresearch:mainfrom
voidborne-d:fix-readme-unzip-typo

Conversation

@voidborne-d
Copy link
Copy Markdown

Fixes #13 (partially)

Problem

The README instructs users to extract experiment logs with:

zip -s 0 outputs_os_parts.zip --out unsplit_logs.zip
unzip unsplit_outputs.zip

The first command creates unsplit_logs.zip, but the second command tries to unzip unsplit_outputs.zip — which does not exist. Users following these instructions will get a "file not found" error.

Fix

Changed unzip unsplit_outputs.zipunzip unsplit_logs.zip to match the output filename from the previous command.


Note: Issue #13 also reports that the archive files are Git LFS pointers (133-135 bytes each) rather than actual data. This PR fixes the command typo; the LFS issue may need separate attention (e.g., uploading actual files or providing an alternative download link).

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Mar 28, 2026

Hi @voidborne-d!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

zip -s 0 outputs_os_parts.zip --out unsplit_logs.zip
unzip unsplit_outputs.zip
unzip unsplit_logs.zip
```
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20260325-064416.png

IMG_20250716_150744.jpg

IMG_20250716_150801.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Experiment logs archive in README cannot be downloaded/extracted (LFS objects missing, unzip command typo?)

2 participants