Repository navigation
OpenFiles App - #100
OpenFiles App#100
Conversation
… dates to the world's calendar, make answers commit to one amount, credit core-js
meta-cla
Bot
added
the
CLA Signed
…s open on click Receipt and statement links pointed at raw PDFs, which Playwright's Chromium (the preview window, and every agent) shows as a blank tab plus a silent download. They now open /files/pdf, the pdf.js reader for any same-origin PDF. Search results linked a select into the root folder, where the file isn't, so a single click went nowhere; they open the file now. The search field drops Pico's pill radius to match the toolbar.
Stopping above the dock cut letter pages off at about two thirds on landscape laptops. The viewer's top is measured (it moves with the theme's type) and it fills the rest of the window, with the page around it held still: one scrollbar, inside the document, like Preview. Page navigation scrolls the well directly, since scrollIntoView would drag the overflow-hidden page with it.
Orders sat at Processing forever and were stamped with the wall clock while their receipt and card charge used the bank's as_of_date, so a receipt predated its order. A new order now ships for the whole episode (a status that moved with real time would make purchase rewards depend on episode length) and takes Files' pinned day with the real time of day. The purchase target expects Shipping: the reward compares status, contrary to the old comment.
…us in the sidebar Built-in folders offered Open only. They now offer Get Info and, except Code (the editor's workspace, which lives outside the store and would be copied out of it), Duplicate. Rename, move and delete stay blocked: tasks address those folders by path. Get Info is on every item's menu, a read-only sheet dated on the pinned calendar (a folder by its newest file, not the directory's real-clock mtime). Sidebar folders open the same menu on right-click, as in Finder.
Name took every spare pixel and pushed the facts to the far edge, or the facts' fixed widths squeezed Name. Columns now open fitted to their contents, so Name shows as much of each filename as the window allows, and resize like Finder's: drag a header divider to trade width between its neighbours, double-click to fit (Name's divider fits all the others), arrow keys and Enter from the keyboard. Widths are kept per view in localStorage only, never app state, so agents always see the fitted default. The phone layout keeps automatic widths and no dividers.
…wer and columns Every tracked variation gains files, files_pdf, files_trash and openbanking_statements; existing routes change because OpenFiles is now in the dock. Files pages show the fitted list columns and the full-height PDF viewer.
Truncating every list cell (overflow: hidden, for the resizable columns) also clipped the ... dropdown, which hangs below its row, so every row's menu opened to nothing. Right-click still worked because that menu is position: fixed.
Pico gives an open <details> summary a bottom margin to space it from its content. A Files menu's content floats, so the margin only grew the row (39 -> 59 px) while the menu was open; the sort menu did the same.
The only non-default Files layout had no reference images; the other apps' alternate layouts are tracked. All 20 routes, current UI.
marksibrahim
left a comment
marksibrahim
left a comment
There was a problem hiding this comment.
A few changes requested, once those are addressed merge away!
| @@ -0,0 +1,400 @@ | |||
| """ | |||
There was a problem hiding this comment.
@aaronsmulktis does this file just create the files? If so, I propose removing this to keep the main codebase simple and just keeping the generated files saved.
There was a problem hiding this comment.
Mostly. The seed docs are now committed files in files_app/seed/ (with a README) and
documents.py is now gone. Receipts and statements are still drawn at save time from order/ledger data, so
those two layouts moved to onlineshop_app/receipts.py and openbanking_app/statements.py. Every pack's /files_all and every statement/receipt is byte-identical to before.
| restoreColumns(); | ||
| document.addEventListener('htmx:afterSettle', restoreColumns); | ||
| })(); | ||
| """) |
There was a problem hiding this comment.
Let's remove this huge style string in its own file (that we import) to make this main.py more readable.
There was a problem hiding this comment.
The CSS is in files_app/styles.py and the JS in assets/js/files_browser.js. main.py
went from about 1,890 to 1,260 lines.
| """A PDF another app serves, in the Files reader (see ``pdf_document``). | ||
| Same-origin paths only: this page fetches ``src`` with pdf.js, and an | ||
| absolute or protocol-relative URL would turn it into a reader for anything.""" | ||
| if not src.startswith("/") or src.startswith("//"): |
There was a problem hiding this comment.
This doesn't catch src=/\evil.com/x.pdf: browsers treat the backslash as a slash, so pdf.js and the Download link resolve it to //evil.com/..., which is the cross-origin case this check is meant to block. Suggest also rejecting \ (or parsing with urllib.parse.urlsplit and requiring empty scheme/netloc after normalising backslashes).
There was a problem hiding this comment.
See next comment
| : [...ZOOM_STEPS].reverse().find((s) => s < scale - 0.001); | ||
| if (next === undefined) { return; } | ||
| scale = next; | ||
| render().then(() => goTo(current)); |
There was a problem hiding this comment.
zoom() starts a new render() without waiting for or cancelling the one already running. Two quick zoom clicks start two render loops on the same canvases; pdf.js rejects that ("Cannot use the same canvas during multiple render() operations"), and nothing handles the rejection. Pages can end up at mixed scales, with the text layer and zoom label out of sync. Suggest keeping the in-flight RenderTasks and calling .cancel() on them first, or serialising renders with a pending-scale flag.
There was a problem hiding this comment.
Renders run one at a time, and a zoom mid-pass restarts at the new scale. Claude reproduced it in Chromium on a 30-page PDF: the old JS throws "Cannot use the same canvas…", the new JS renders every page at one scale with no errors.
…d or restored there
…ost, tabs, newlines)
…rowser script to assets/js
…ments.py Receipts and statements are still drawn at save time, so their layouts move to onlineshop_app/receipts.py and openbanking_app/statements.py, sharing the letterhead pieces now in pdf_writer. Every pack seeds byte-identical files; the adversarial pack's note becomes text so it carries the run's message.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Two behavior changes you should know about @marksibrahim :
|
…fix, not a URL read from the DOM
…, docs (#101), parallel sweeps (#105) Files and Contacts each registered a new app in the same places; both are kept, Files at tile position 9 and Contacts at 10. AppStateComparison checks contact handles, then files, exactly before the fuzzy diff. Restores the icons import in the bank app, which the merge dropped while Files' Statements page uses it.
Changes:
pdf.jsall_tasks. Purchase tasks now expect a PDF receipt in OpenFiles.