Skip to content
This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions fbpcp/service/container.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,3 @@ def get_current_instances_count(self) -> int:
Integer that represent the total pending and running instances count for cluster
"""
pass

@abc.abstractmethod
def validate_container_definition(self, container_definition: str) -> None:
"""Validate the format of a specific container definition.
Raises:
InvalidParameterError: The container definition is not in a valid format.
"""
pass
4 changes: 0 additions & 4 deletions fbpcp/service/onedocker.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ def __init__(
if container_svc is None:
raise ValueError(f"Dependency is missing. container_svc={container_svc}, ")
self.container_svc = container_svc
if task_definition:
self.container_svc.validate_container_definition(task_definition)
self.task_definition = task_definition
self.metrics: Final[Optional[MetricsEmitter]] = metrics
self.logger: logging.Logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -140,8 +138,6 @@ def start_containers(
Returns:
A list of the containers that were successfuly started
"""
if task_definition:
self.container_svc.validate_container_definition(task_definition)
if not cmd_args_list:
raise ValueError("Command Argument List shouldn't be None or Empty")

Expand Down